Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ExprTarget to use raytracing #5947

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Change ExprTarget to use raytracing #5947

merged 4 commits into from
Aug 29, 2023

Conversation

TheLimeGlass
Copy link
Contributor

Description

Change ExprTarget to use raytracing.

Also added a test to ensure yaw and pitch matches after indirect modification.

Target Minecraft Versions: any
Requirements: none
Related Issues: #5650

@TheLimeGlass TheLimeGlass added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 27, 2023
sovdeeth
sovdeeth approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I do believe this may be a slightly breaking change, but only in a good way as it will result in less false positives. Unsure if that's worth adding the breaking changes tag for. Probably not.

@AyhamAl-Ali
Copy link
Member

Very nice! I do believe this may be a slightly breaking change, but only in a good way as it will result in less false positives. Unsure if that's worth adding the breaking changes tag for. Probably not.

I would say it's just improved since it has less false positives now

@AyhamAl-Ali AyhamAl-Ali merged commit 27106e2 into master Aug 29, 2023
@AyhamAl-Ali AyhamAl-Ali deleted the feature/raytrace-target branch August 29, 2023 10:19
Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023
@TheLimeGlass @Moderocky
Change ExprTarget to use raytracing (SkriptLang#5947)
2ba4218
NotSoDelayed pushed a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023
@TheLimeGlass @NotSoDelayed
Change ExprTarget to use raytracing (SkriptLang#5947)
cd6f199
@sovdeeth sovdeeth mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pikachu920 Pikachu920 Pikachu920 left review comments

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheLimeGlass @AyhamAl-Ali @sovdeeth @Moderocky @Pikachu920