Allow 'continue' the continue outer loops

[UnderscoreTud]

Description

This PR adds the ability to continue parent loops from within an inner loop. Loops are numbered from 1 to n and goes from outer to inner. For example:

loop all players: # Loop 1
    loop {values::%loop-value%::*}: # Loop 2
        set {_x} to foo(loop-value-2)
        if {_x} < 10:
            continue the 1st loop # Continues the 'loop all players' loop
    bar(loop-value)
    broadcast "Player has valid values!"

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #6012

[Moderocky]

Good

[Pikachu920]

could we add some tests for this?

[Moderocky]

Tests are a good idea!

[sovdeeth]

When using continue loop without any specific number, the outer-most loop is continued instead of the inner-most.

command test:
    trigger:
        loop 3 times:
            broadcast "%loop-value%"
            loop 3 times:
                broadcast "- %loop-value-2%"
                loop 3 times:
                    broadcast "  - %loop-value-3%"
                    if loop-value-1 is 2, 5, or 8:
                        continue loop

[22:56:53 INFO]: 1
[22:56:53 INFO]: - 1
[22:56:53 INFO]:   - 1
[22:56:53 INFO]:   - 2
[22:56:53 INFO]:   - 3
[22:56:53 INFO]: - 2
[22:56:53 INFO]:   - 1
[22:56:53 INFO]:   - 2
[22:56:53 INFO]:   - 3
[22:56:53 INFO]: - 3
[22:56:53 INFO]:   - 1
[22:56:53 INFO]:   - 2
[22:56:53 INFO]:   - 3
[22:56:53 INFO]: 2
[22:56:53 INFO]: - 1
[22:56:53 INFO]:   - 1
[22:56:53 INFO]: 3
[22:56:53 INFO]: - 1
[22:56:53 INFO]:   - 1
[22:56:53 INFO]:   - 2
[22:56:53 INFO]:   - 3
[22:56:53 INFO]: - 2
[22:56:53 INFO]:   - 1
[22:56:53 INFO]:   - 2
[22:56:53 INFO]:   - 3
[22:56:53 INFO]: - 3
[22:56:53 INFO]:   - 1
[22:56:53 INFO]:   - 2
[22:56:53 INFO]:   - 3

[Fusezion]

Just a quick mild suggest to the pattern, I'd also like to mention the possibility in syntax like continue loop-3 I don't like the current method of forcing nd, rd, st or th and skript already has syntax similar to continue loop-3 in our loop-value-2

[Fusezion]

I think something like this might be a slightly better design, not only fixes the issue that was brought up about continue loop being a breaking change currently but seems like a little bit easier design to read this way anything using the number can be treated as it's respectful format

Suggested change

	Skript.registerEffect(EffContinue.class, "continue [[this|[the] (%*integer%(st|nd|rd|th)|current)] loop]");
	}
	Skript.registerEffect(EffContinue.class,
	"continue [[this|the [current]] loop]",
	"continue [the] %*integer%(st|nd|rd|th) loop"
	);
	}

[Moderocky]

I think some tests would be good for this as pikachu suggested :)

[UnderscoreTud]

When using continue loop without any specific number, the outer-most loop is continued instead of the inner-most.

Ah, thanks for the catch!

[AyhamAl-Ali]

Well done ⚡