Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the multiple event-values less strict #6122

Merged
merged 10 commits into from
Jan 1, 2024

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Oct 14, 2023

Description

The pull request of #5769 makes Skript error when not defining an exact event value. After actively using it. I find it to be too strict.

This pull request eases the error warning to only happen to assignable types.

See unacceptable errors
errors

Other

  • dev/feature is not updated to master on skript-aliases, so this pull request is updating that to master.
  • This is targetting 2.8 because this error handling was introduced in 2.8.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.8 Targeting a 2.8.X version release labels Oct 14, 2023
@AyhamAl-Ali
Copy link
Member

I think aliases update should be separated from this PR into its own with merging dev/patch to dev/feature as we do every so often due to our latest release model

@TheLimeGlass
Copy link
Contributor Author

I think aliases update should be separated from this PR into its own with merging dev/patch to dev/feature as we do every so often due to our latest release model

It'll be hard to find the exact commit the master branch is on. We should make a GitHub action to keep the aliases updated on the dev/feature and dev/patch from master

@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 30, 2023
@sovdeeth sovdeeth merged commit d0ed4fc into dev/feature Jan 1, 2024
5 checks passed
@sovdeeth sovdeeth deleted the fix/multiple-event-values branch January 1, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants