Ask for player's groups off the main thread. #6192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version should support 1.13 to 1.17+ according to the Spigot page. I'm not sure what this actually adds but it's usually a good idea to keep dependencies updated and all 1.7.X versions of Vault are supposed to be compatible. :)
This change is (basically) pointless -- we still block the main thread while we wait since we absolutely need to, but it prevents the errors from overzealous permissions plugins.
Pikachu920
approved these changes
Nov 19, 2023
|
actually, would this cause potential new issues with other permission plugins that may expect/require the API to be called from the main thread? |
No idea, I'm fairly sure PermissionsEx is old enough that it doesn't care but I don't know about any other permissions plugins (if there are any) -- the only report we've had is LuckPerms so we could do it on a different thread iff LuckPerms is present but then that wouldn't fix it if anything else had the same requirement (or if our check didn't catch everything) |
AyhamAl-Ali
added
the
enhancement
AyhamAl-Ali
approved these changes
Nov 20, 2023
|
If somebody knows what permissions plugins are used currently they could test this. |
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the matched vault version to 1.7.3.
LuckPerms is a little overzealous and prints a giant error when requesting groups on the main thread using the vault hook.
Since
player's group[s]is an expression Skript doesn't have the option of waiting for it to resolve on a background thread.My solution was to do the call in a completable future and block while waiting for it to resolve, so it effectively does the same thing as before without triggering the error.
Obviously this isn't ideal, but it seemed better than trying to disable the LuckPerms check specifically while the server was running.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5692