Fix CondCompare Logging #6266
Merged
Fix CondCompare Logging #6266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
Fusezion
suggested changes
Dec 29, 2023
TheLimeGlass
approved these changes
Dec 29, 2023
AyhamAl-Ali
approved these changes
Dec 29, 2023
sovdeeth
approved these changes
Dec 30, 2023
sovdeeth
added
the
feature-ready
|
I'm not sure of any easy way to test this as the errors did not occur with a vanilla Skript installation. I think it will be alright without a test since the changes are minimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes logging problems with CondCompare that were the cause of the issue below. The errors in the linked issue are ghost errors from CondCompare reparsing literals to find a good comparison. The problem is, even when CondCompare is successful, it prints the entire log which includes errors from failed Classes.parse attempts.
To combat this issue, I have replaced the RetainingLogHandler with a ParseLogHandler. When it needs to print an error, it will print the most recent/relevant error. At the end, when successful, it will print all non-error log messages (e.g. warnings that are likely to be applicable).
Target Minecraft Versions: any
Requirements: none
Related Issues: