Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Erroneous Player UUID Warnings #6287

Conversation

APickledWalrus
Copy link
Member

Description

This PR fixes an issue with the warning introduced in #6271 where it would print for all usages of a player-returning expression. I have updated the check to ensure it is actually a variable being parsed.

Below is an example of the issue:
image
(photo credit @ShaneBeee)


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@APickledWalrus APickledWalrus added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.8 Targeting a 2.8.X version release labels Jan 2, 2024
@AyhamAl-Ali AyhamAl-Ali added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jan 2, 2024
@APickledWalrus APickledWalrus merged commit 59caa86 into SkriptLang:dev/feature Jan 5, 2024
4 checks passed
@APickledWalrus APickledWalrus deleted the fix/player-uuid-variable-warnings branch January 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants