-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Location -> Chunk Converter #6302
Remove Location -> Chunk Converter #6302
Conversation
Is there any information that this solves anything? What are the related issues? Does it fix them? What would be the point of this pull request if it's just speculation? |
Adding converters may break anything in Skript as they are sensitive when it comes to allow other expressions which are not meant to be converted. |
We may want to wait on this until 2.9, though, as it is technically a breaking change, to my knowledge.
|
If this currently fetches all the blocks in the chunk, which I'm assuming it does from context, this seems like extremely unintended behaviour and I'm very happy to call that a mistake and allow this in the patch version. |
Good point. I'd agree. |
Remove Location -> Chunk converter Co-authored-by: Moderocky <admin@moderocky.com>
Description
The Location -> Chunk converter was introduced in #5447 to make use of event locations as event chunks, which it may cause inaccurate event chunk results, fixed in #5965, but the converter was not removed prior to that PR.
This PR removes it to prevent any further unexpected behaviour, such as using location parameters in expressions accepting chunks.
Target Minecraft Versions: any
Requirements: none
Related Issues: none