Add support for character codepoints #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get tests for this? Have you tested with negative numbers, infinities, NaN, etc? |
AyhamAl-Ali
reviewed
Mar 29, 2024
src/main/java/ch/njol/skript/expressions/ExprCharacterFromCodepoint.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Mar 30, 2024
Comment on lines
+55
to
+57
| public String convert(Integer integer) { | ||
| return String.valueOf((char) integer.intValue()); | ||
| } |
There was a problem hiding this comment.
Do you think it's worth clamping values instead of allowing negative values to wrap around? I think it's fine either way but -1 = 65535 might be a bit confusing for users.
AyhamAl-Ali
approved these changes
Mar 30, 2024
sovdeeth
added
the
feature-ready
sovdeeth
requested changes
May 8, 2024
src/main/java/ch/njol/skript/expressions/ExprCharacterFromCodepoint.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCharacterFromCodepoint.java
Outdated
Show resolved
Hide resolved
sovdeeth
removed
the
feature-ready
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
approved these changes
May 8, 2024
Moderocky
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two expressions allowing you to get the codepoint of a character and get a character at a codepoint
Target Minecraft Versions: any
Requirements: none
Related Issues: none