Add "invincible" as a synonym of "invulnerable" in related syntaxes. #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
AyhamAl-Ali
approved these changes
Feb 2, 2024
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
APickledWalrus
approved these changes
Feb 2, 2024
sovdeeth
added
the
feature-ready
|
i like the change. can we also add invincible as doc keywords ( |
no need to since it is in the pattern now and the docs search does look in patterns for matches :D |
Moderocky
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syntaxes that use "invulnerable" will also allow "invincible" as well, to reduce confusion and make it slightly more likely someone can write the syntax from memory.
Target Minecraft Versions: any
Requirements: none
Related Issues: none