Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MC 1.20.5 Attributes #6413

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to get a head start on attributes coming in Minecraft 1.20.5

NOTE:

Please do not merge until just before release of next Skript update
In the event MC adds more attributes in the coming weeks, Ill update this PR


Target Minecraft Versions: 1.20.5+
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Feb 7, 2024
@Moderocky
Copy link
Member

Is it okay to mark this as draft so that nobody (probably me) accidentally merges it too early?

@ShaneBeee
Copy link
Contributor Author

I think its probably ok to merge.
They haven't added any new Attributes lately, Im kinda hoping they're ramping down on new stuff and head towards a release.
That said, I can always do another PR later if they add more attributes, but I doubt they will.

@Moderocky
Copy link
Member

Sounds good.

@Moderocky Moderocky merged commit 6fe77c8 into SkriptLang:dev/patch Mar 29, 2024
4 checks passed
@ShaneBeee ShaneBeee deleted the dev/attributes2 branch March 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants