Add case-insensitive commands toggle in config.sk #6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
Moderocky
approved these changes
Apr 24, 2024
APickledWalrus
approved these changes
May 5, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5966 inadvertently caused Skript to stop parsing commands as case insensitive, since it now just defers to the Bukkit logic, which only accepts lowercase commands. This PR maintains this new behavior by default, but adds an optional config flag to pre-process incoming skript commands and force them to be lowercase. This allows users to use /test, /TEST, and /teST interchangeably, if they so wish.
Note that console commands are already case insensitive by default, so no logic was needed in that listener.
Target Minecraft Versions: any
Requirements: none
Related Issues: none