Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config toggle for whether to listen to cancelled events by default. #6680

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented May 9, 2024

Description

Adds a config option to allow on <event> events to listen to cancelled events.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.9 Targeting a 2.9.X version release labels May 9, 2024
src/main/resources/config.sk Outdated Show resolved Hide resolved
Co-authored-by: _tud <98935832+UnderscoreTud@users.noreply.github.com>
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! Thanks.
Not that my approval is needed but here you go, you can have it anyways

@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 13, 2024
@sovdeeth sovdeeth merged commit 1a42f52 into SkriptLang:dev/feature Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants