Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whether expression for getting the result of conditions. #6748

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Whether expression for getting the result of conditions. #6748

merged 8 commits into from
Jun 28, 2024

Conversation

Moderocky
Copy link
Member

@Moderocky Moderocky commented May 31, 2024 •
edited by APickledWalrus
Loading

Description

Adds a whether %condition% expression that returns the (true/false) evaluation of the condition.
For example:

  • set {_flying} to whether player is flying
  • set {_alive} to whether player is alive
  • send "Alive: %whether player is alive%"

Target Minecraft Versions: any
Requirements: none
Related Issues:

@Moderocky Moderocky requested a review from sovdeeth May 31, 2024 15:13
@sovdeeth sovdeeth added feature Pull request adding a new feature. 2.9 Targeting a 2.9.X version release labels May 31, 2024
Moderocky and others added 3 commits May 31, 2024 16:30
@Moderocky @APickledWalrus
Apply suggestions from code review
746c5da 
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
@Moderocky
Fix ternary + toString.
46e35e6
@Moderocky @sovdeeth
Update src/main/java/ch/njol/skript/expressions/ExprWhether.java
81bc2fe 
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@Moderocky Moderocky requested a review from APickledWalrus May 31, 2024 15:32
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 31, 2024
@Moderocky Moderocky requested a review from UnderscoreTud June 2, 2024 12:41
@sovdeeth sovdeeth mentioned this pull request Jun 22, 2024
Closed
1 task
@sovdeeth sovdeeth merged commit 39acfe3 into SkriptLang:dev/feature Jun 28, 2024
5 checks passed
@APickledWalrus APickledWalrus mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

Assignees
No one assigned
Labels
2.9 Targeting a 2.9.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moderocky @sovdeeth @APickledWalrus @UnderscoreTud