Fix firework spawning #6764
Merged
Fix firework spawning #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
sovdeeth
approved these changes
Jun 3, 2024
Moderocky
approved these changes
Jun 4, 2024
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix fireworks not being able to be spawned. This issue was caused by #6523, as Fireworks are (for whatever reason) considered not spawnable.
@sovdeeth has opened an issue with Spigot: https://hub.spigotmc.org/jira/browse/SPIGOT-7677
I've added additional API for a SimpleEntityData to specify whether it overrides the canSpawn behavior. I'm not sure if we would wish to expand it to properly check for entities blocked by experiments.
Target Minecraft Versions: any
Requirements: none
Related Issues: