Allows for multiple return types in ExpressionEntryData #6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the constructors to allow for multiple return types - Changes the calls to SkriptParser#parseExpression to pass in the array of types
|
Why use a list if you're just going to be converting to an array every time? Just use an array. |
sovdeeth
added
the
enhancement
- Changes returnTypes field to an array - Adds 2 new constructors, one which has the flags parameter and the other that defaults to ALL_FLAGS
sovdeeth
approved these changes
Jul 7, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes:
This is my first time doing anything that modifies Skript in this way, so would love to know if anything needs attention.
Target Minecraft Versions: any
Requirements: none
Related Issues: none