Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pufferfish as entitydata #6919

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Jul 18, 2024

Description

allows pufferfish as entitydata instead of just puffer fish

related: SkriptLang/skript-aliases#116


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 18, 2024
@Fusezion
Copy link
Contributor

This doesn't conflict with the item correct? As I believe that's the reason it doesn't exist already

@sovdeeth
Copy link
Member Author

This doesn't conflict with the item correct? As I believe that's the reason it doesn't exist already

not in my testing

@TheLimeGlass
Copy link
Collaborator

This doesn't conflict with the item correct? As I believe that's the reason it doesn't exist already

I fixed that, it will reparse if it's incorrect to get the required type.

@sovdeeth
Copy link
Member Author

This doesn't conflict with the item correct? As I believe that's the reason it doesn't exist already

I fixed that, it will reparse if it's incorrect to get the required type.

are you referring to #5504 ?

@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. 2.9 Targeting a 2.9.X version release labels Jul 24, 2024
@APickledWalrus APickledWalrus merged commit a30b33f into SkriptLang:dev/patch Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants