Bandaid fix for single quotes in command args #6936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
Pikachu920
reviewed
Jul 22, 2024
src/test/skript/tests/regressions/pull-6936-single quotes in commands.sk
Show resolved
Hide resolved
Pikachu920
reviewed
Jul 22, 2024
src/test/skript/tests/regressions/pull-6936-single quotes in commands.sk
Show resolved
Hide resolved
APickledWalrus
approved these changes
Jul 24, 2024
UnderscoreTud
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually escapes single quotes in the generated command usage message to avoid errors when trying to use single quotes as command arguments. The fix is a bandaid as there are many more problems with command parsing/argument parsing that should be addressed:
command test %now%being a good example. This can come in a later pr.Target Minecraft Versions: any
Requirements: none
Related Issues: none