Fix ExprRemainingAir Negative Value Handling #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
sovdeeth
approved these changes
Jul 31, 2024
Moderocky
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix ExprRemainingAir issues with negative value handling. It is possible for the API to return a negative value (from -1 to -19). This appears to be used for controlling when damage occurs. I have elected to interpret negative values as 0 seconds. Additionally, while it is possible to use any negative values, the behavior is a bit strange and unlikely to be useful. I have also removed the upper limit of 10000 seconds. I was unable to replicate any client or server issues from high values. It seems to count down when in water as expected.
Target Minecraft Versions: any
Requirements: none
Related Issues: