Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when reloading Skript. #6958

Merged
merged 12 commits into from
Oct 13, 2024

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Aug 4, 2024

Description

Added a warning when Skript is reloaded.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

Copy link
Contributor

@EquipableMC EquipableMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line 933, it should be better worded in my honest opinion. Maybe something like:
"Hey! It looks like you've used the /reload command or used a plugin to reload Skript. This is not supported and will cause issues!"

@Asleeepp
Copy link
Contributor Author

Asleeepp commented Aug 4, 2024

For line 933, it should be better worded in my honest opinion. Maybe something like: "Hey! It looks like you've used the /reload command or used a plugin to reload Skript. This is not supported and will cause issues!"

I don't think something like this fits Skript, Skript is more formal in my eyes, Stuff like "Hey!" and stuff like that, shouldn't be used in this, thats my view on it.
Other Skript warnings/errors are also very formal and direct like I've written it here.

@EquipableMC
Copy link
Contributor

For line 933, it should be better worded in my honest opinion. Maybe something like: "Hey! It looks like you've used the /reload command or used a plugin to reload Skript. This is not supported and will cause issues!"

I don't think something like this fits Skript, Skript is more formal in my eyes, Stuff like "Hey!" and stuff like that, shouldn't be used in this, thats my view on it. Other Skript warnings/errors are also very formal and direct like I've written it here.

I mean my comment can be up for debate, but yeah I understand where you're coming from

@Asleeepp Asleeepp requested a review from sovdeeth August 4, 2024 18:54
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth August 4, 2024 19:39
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine with efnilite's changes

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 14, 2024
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from Moderocky August 30, 2024 16:15
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 23, 2024
@sovdeeth sovdeeth merged commit cf244fa into SkriptLang:dev/feature Oct 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants