Unreachable Code #6960
Merged
Unreachable Code #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Moderocky
approved these changes
Aug 6, 2024
…chable code warning using config or the suppress warning effect
sovdeeth
requested changes
Aug 11, 2024
APickledWalrus
requested changes
Aug 14, 2024
src/main/java/org/skriptlang/skript/lang/script/ScriptWarning.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Aug 14, 2024
sovdeeth
added
the
enhancement
|
Also, I am a little unsure about the config option. I don't think that it is necessary given the suppress effect exists. I'd like to see what others think though. |
All warnings that may be suppressed by the suppress effect, excluding the deprecated syntax warning, have a config option equivalent. So, I think it's more consistent that way. |
…is even happened in the first place)
APickledWalrus
requested changes
Sep 4, 2024
UnderscoreTud
added
the
bug
…e and there are no sections present
APickledWalrus
requested changes
Sep 16, 2024
# Conflicts: # src/main/java/ch/njol/skript/effects/EffContinue.java # src/main/java/ch/njol/skript/effects/EffExit.java # src/main/java/ch/njol/skript/effects/EffReturn.java # src/main/java/ch/njol/skript/effects/EffSuppressWarnings.java
APickledWalrus
approved these changes
Sep 22, 2024
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a warning for unreachable code using a new API that gives statements/sections a way to define what happens after its execution.
Currently, the Intent API only supports "stop" intentions.
As well as fixing a bug where the
returneffect would always stop the trigger rather than just the returning section.Target Minecraft Versions: any
Requirements: none
Related Issues: none