Fix Message when reloading multiple scripts with an error. #7031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should just change the light green to light red. nothing should be green in that message imo |
sovdeeth
added
bug
would you like me to do it for the other langs too? since its just a color change should be fairly simple |
Moderocky
requested changes
Sep 4, 2024
There was a problem hiding this comment.
This was made green because of #6136.
Unfortunately, we didn't know at the time it's also used in another place (which was presumably why it was left white to begin with).
You're either going to have to separate it into two language nodes or find some colour that works for both.
Moderocky
approved these changes
Sep 15, 2024
Efnilite
approved these changes
Sep 23, 2024
UnderscoreTud
approved these changes
Sep 30, 2024
UnderscoreTud
added
the
patch-ready
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed while updating my server (and i had some errors) that when i reloaded an entire folder, the "in" was colored green, which looked pretty strange. this pr fixes that.
Although, not sure if lime is even used much across Skript (apart from reloading correctly), so maybe the lime color should just be changed overall. lmk!
Not sure if you guys want it in the other langs too, but im not sure how i could do that, im not a polyglot 🤷
Target Minecraft Versions: any
Requirements: none
Related Issues: none