Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockDropItemEvent #7075

Merged
merged 20 commits into from
Oct 13, 2024
Merged

BlockDropItemEvent #7075

merged 20 commits into from
Oct 13, 2024

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to add the BlockDropItemEvent

Target Minecraft Versions: any
Requirements: none
Related Issues: #5959

@TheAbsolutionism
Starter Commit
fff261f
@TheAbsolutionism
Test Variations
953e5d7 
Logging for a copy,  will be removed
@TheAbsolutionism
PR Ready
c39d5f9
@TheAbsolutionism
Merge branch 'dev/feature' into dev/onblockdrop
d737afc
@TheAbsolutionism
Stuff
cc43747 
Forgot to add back the return if none of the events in ExprDrops
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 13, 2024
Efnilite
Efnilite requested changes Sep 14, 2024
View reviewed changes
src/main/java/ch/njol/skript/events/EvtBlock.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtBlock.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtBlock.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtBlock.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDrops.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing left that i missed earlier

src/main/java/ch/njol/skript/expressions/ExprDrops.java Outdated Show resolved Hide resolved
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 30, 2024
@sovdeeth sovdeeth merged commit 790c779 into SkriptLang:dev/feature Oct 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheAbsolutionism @sovdeeth @TheLimeGlass @Efnilite