Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a condition for is divisible by #7104

Merged
merged 30 commits into from
Oct 26, 2024
Merged

Adds a condition for is divisible by #7104

merged 30 commits into from
Oct 26, 2024

Conversation

EquipableMC
Copy link
Contributor

Description

This PR simply adds a condition to check if a number is divisible by another number, without having to use the mod function.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Efnilite
Efnilite requested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and tests!

src/main/java/ch/njol/skript/conditions/CondIsDivisibleBy.java Outdated Show resolved Hide resolved
@EquipableMC
Copy link
Contributor Author

and tests!

😭 okay

@Romitou Romitou added the feature Pull request adding a new feature. label Sep 21, 2024
Asleeepp
Asleeepp suggested changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@Asleeepp Asleeepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix previous suggestion

src/test/skript/tests/syntaxes/conditions/CondIsDivisibleBy.sk Outdated Show resolved Hide resolved
TenFont
TenFont suggested changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@TenFont TenFont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a negated version of the pattern should exist.
Something like if {_number} is not divisible by 8: should be possible.

@EquipableMC
Copy link
Contributor Author

I believe a negated version of the pattern should exist. Something like if {_number} is not divisible by 8: should be possible.

added!

Pikachu920
Pikachu920 requested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@Pikachu920 Pikachu920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay english

src/test/skript/tests/syntaxes/conditions/CondIsDivisibleBy.sk Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsDivisibleBy.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsDivisibleBy.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsDivisibleBy.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsDivisibleBy.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/conditions/CondIsDivisibleBy.sk Show resolved Hide resolved
Phill310
Phill310 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Phill310 Phill310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright overall

src/main/java/ch/njol/skript/conditions/CondIsDivisibleBy.java Outdated Show resolved Hide resolved
@EquipableMC EquipableMC requested a review from sovdeeth October 4, 2024 01:34
@sovdeeth sovdeeth requested review from TenFont and Asleeepp October 12, 2024 04:41
@EquipableMC EquipableMC requested a review from Asleeepp October 12, 2024 11:14
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Oct 12, 2024
@sovdeeth sovdeeth merged commit a3d490b into SkriptLang:dev/feature Oct 26, 2024
5 checks passed
@EquipableMC EquipableMC deleted the CondDivisible branch October 31, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asleeepp Asleeepp Asleeepp approved these changes

@TenFont TenFont TenFont approved these changes

@Phill310 Phill310 Phill310 approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Romitou Romitou Romitou approved these changes

@Pikachu920 Pikachu920 Pikachu920 approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@EquipableMC @TenFont @sovdeeth @Pikachu920 @Romitou @Efnilite @Phill310 @Asleeepp