Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool Components #7200

Open
wants to merge 10 commits into
base: dev/feature
Choose a base branch
from
Open

Tool Components #7200

wants to merge 10 commits into from
+1,003 −49

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to add support for the upcoming Tool Components to Skript.

This will be marked as draft due to Tool Components being ApiStatus.Experimental at this time.
Open to any syntax changes.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Fusezion
Fusezion suggested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's 19 reviews to eventually be completed or ignored idk

src/main/java/org/skriptlang/skript/bukkit/toolcomponent/ToolRuleWrapper.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/ToolRuleWrapper.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/CondToolRuleDrops.java Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/EffSecCreateToolRule.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/EffSecCreateToolRule.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolCompRules.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolCompRules.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolRuleBlocks.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolRuleBlocks.java Outdated Show resolved Hide resolved
src/main/java/org/skriptlang/skript/bukkit/toolcomponent/elements/ExprToolRuleSpeed.java Outdated Show resolved Hide resolved
@Romitou Romitou added the feature Pull request adding a new feature. label Nov 8, 2024
@TheAbsolutionism TheAbsolutionism marked this pull request as ready for review November 10, 2024 18:32
Moderocky
Moderocky approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Well done.

@sovdeeth
Copy link
Member

this looks good, but I would like to spend some more time investigating more cohesive ways to implement all the item components so I think this would be best for 2.11. Components are a major requirement to sunset aliases and something I'd like to have fully implemented for 2.11 rather than rushing into 2.10.

@TheAbsolutionism
Copy link
Contributor Author

this looks good, but I would like to spend some more time investigating more cohesive ways to implement all the item components so I think this would be best for 2.11. Components are a major requirement to sunset aliases and something I'd like to have fully implemented for 2.11 rather than rushing into 2.10.

That's fine, I never expected this to be merged for 2.10 because Tool Components (Same with Equippable Components) are still experimental. Was just setting up a base at the very least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fusezion Fusezion Fusezion requested changes

@Moderocky Moderocky Moderocky approved these changes

@Efnilite Efnilite Awaiting requested review from Efnilite

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature Pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheAbsolutionism @sovdeeth @Moderocky @Efnilite @Fusezion @Romitou