ItemUtils#changeItemMeta, #setItem

[TheAbsolutionism]

Description

This PR is to help with shorthand ItemStack changes.
Example: (Before)

for (Object object : getExpr().getArray(event)) {
    ItemStack item = ItemUtils.asItemStack(object);
    if (item == null)
        continue;
    ItemMeta meta = item.getItemMeta();
    consumer.accept(meta);
    item.setItemMeta(meta);
    if (object instanceof Slot slot) {
        slot.setItem(item);
    } else if (object instaceof ItemType itemType) {
        itemType.setItemMeta(meta);
    } else if (object instanceof ItemStack itemStack) {
        itemStack.setItemMeta(meta);
    }
}

(After)

for (Object object : getExpr().getArray(event)) {
    ItemStack item = ItemUtils.asItemStack(object);
    if (item == null)
        continue;
    ItemUtils.setItem(object, ItemUtils.changeItemMeta(item, consumer));
}

Obviously this will more than likely be up for debate but here's hoping.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: none

[APickledWalrus]

Looks good. It might be nice to have a changeItemMeta method that lets you work with specific ItemMeta implementations. See https://jd.papermc.io/paper/1.19/org/bukkit/inventory/ItemStack.html#editMeta(java.lang.Class,java.util.function.Consumer)

[TheAbsolutionism]

Looks good. It might be nice to have a changeItemMeta method that lets you work with specific ItemMeta implementations. See https://jd.papermc.io/paper/1.19/org/bukkit/inventory/ItemStack.html#editMeta(java.lang.Class,java.util.function.Consumer)

I thought you had said because my method is almost the exact same as Paper's editMeta, it would be better off leaving as is?

[Fusezion]

Looks good. It might be nice to have a changeItemMeta method that lets you work with specific ItemMeta implementations. See https://jd.papermc.io/paper/1.19/org/bukkit/inventory/ItemStack.html#editMeta(java.lang.Class,java.util.function.Consumer)

I thought you had said because my method is almost the exact same as Paper's editMeta, it would be better off leaving as is?

I believe the idea behind his suggestion is to accept a meta class in the parameter similar to how paper does