-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Dropped Item Elements #7270
base: dev/feature
Are you sure you want to change the base?
Additional Dropped Item Elements #7270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc skript has a type registered for dropped entities can we make use of that instead of entity here so people don't interpret differently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the same as pickle probably
I'm not seeing any registered |
ahhh ok, appreciate it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some concerns I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not a fan of returning null when something isn't null provided by Bukkit/Minecraft.
In my opinion this is super misleading.
ie: if owner/thrower of %itementity% is set:
incorrectly returning false.
But if that is what the team wants, then I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is just about ready. I'm really liking the syntax changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't hate me, mostly just concerns or questions
src/main/java/ch/njol/skript/conditions/base/PropertyCondition.java
Outdated
Show resolved
Hide resolved
@APickledWalrus my main issue is when using this in conjunction with |
@ShaneBeee Yeah, I think that's fair. It could be confusing, though I do think it might as well be not set to the average Skript user (since they can't do anything with it). Of course, I'm operating on the assumption that it being a dead UUID means it is useless, which very well may not be the case. |
I'm ok with it returning a string uuid as a last resort, but I don't think there's a good solution either way. If we return a string uuid, then |
src/main/java/ch/njol/skript/conditions/base/PropertyCondition.java
Outdated
Show resolved
Hide resolved
static { | ||
Skript.registerEffect(EffItemDespawn.class, | ||
"(prevent|disallow) %itementities% from (naturally despawning|despawning naturally)", | ||
"allow natural despawning of %itementities%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say there should be a corresponding
(prevent|disallow) natural despawning of %itementities%
I'm also wondering if natural
should be optional, as in prevent despawning of %itementities%
(not 100% sure on that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know
…tems # Conflicts: # src/main/java/ch/njol/skript/expressions/ExprEntityTamer.java
Description
This PR aims to add additional elements relating to Dropped Items
Target Minecraft Versions: any
Requirements: none
Related Issues: #5110