-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported events #7281
base: dev/feature
Are you sure you want to change the base?
Supported events #7281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a huge fan of this given that it ties events deeper into the api, but i'd like to see what others think.
Yeah I'd rather it stay as is for now, since this should be context-aware in the future when someone cough cough gets around to context api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks ok but I want somebody more familiar with parser to approve this.
If this is a big enough concern we could move the method into its own interface, maybe called |
Description
Adds a method to specify the supported events by this SyntaxElement.
If the current parser event is not supported by the SyntaxElement, prints an error.
This removes the need for these checks in
init
s.Target Minecraft Versions: any
Requirements: none
Related Issues: none