-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elytra Boost #7283
Elytra Boost #7283
Conversation
# Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I mainly have some formatting concerns.
src/main/java/ch/njol/skript/effects/EffElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final touches. Re-request for approval 🙂
src/main/java/ch/njol/skript/effects/EffElytraBoostConsume.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/PlayerElytraBoostEventTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/PlayerElytraBoostEventTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
This PR aims to add Paper's PlayerElytraBoostEvent
Target Minecraft Versions: any
Requirements: none
Related Issues: #5826