Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elytra Boost #7283

Merged
merged 9 commits into from
Dec 24, 2024
Merged

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to add Paper's PlayerElytraBoostEvent


Target Minecraft Versions: any
Requirements: none
Related Issues: #5826

# Conflicts:
#	src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
@APickledWalrus APickledWalrus added the feature Pull request adding a new feature. label Dec 19, 2024
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I mainly have some formatting concerns.

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final touches. Re-request for approval 🙂

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

src/main/java/ch/njol/skript/events/SimpleEvents.java Outdated Show resolved Hide resolved
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 24, 2024
@Moderocky Moderocky merged commit 854e06d into SkriptLang:dev/feature Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants