ExprName - combine elements and cleanup docs #7370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Jan 3, 2025
sovdeeth
approved these changes
Jan 3, 2025
cheeezburga
approved these changes
Jan 3, 2025
cheeezburga
added
enhancement
Moderocky
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to do a big cleanup to ExprName, 2 major changes:
Register 1 element instead of 3. This prevents 3 separate expressions showing up in the docs, making it super confusing when people open the docs, find the first ExprName, and think thats it.
(all 3 elements have the same examples, description, version... only diff is the pattern. Super confusing)
Before:
.
After: (just 1)
Cleanup the weird html list issues in the description.
(removing all the "ul" list things.)
Before:
see docs:
https://docs.skriptlang.org/expressions.html#ExprName-4
(look at description)
After:
Target Minecraft Versions: any
Requirements: none
Related Issues: none