Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JUnit warnings on test runs #7378

Merged
merged 11 commits into from
Jan 14, 2025

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Jan 3, 2025

Description

  • Removes debug broadcasts from classes and furnace event
  • Removes Adjective.toString warning (why is that even there?) for the firework event, and improves performance by using a Set.
  • Fixes backup purge test failing when there are already backups present

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added unit testing For issues/PRs related to the Skript unit testing system. housekeeping Housekeeping-related issue or task. labels Jan 3, 2025
@Efnilite Efnilite requested a review from sovdeeth January 3, 2025 23:54
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jan 8, 2025
@Efnilite Efnilite merged commit 1fd0c93 into SkriptLang:dev/feature Jan 14, 2025
5 checks passed
@Efnilite Efnilite deleted the fix-junit-tests branch January 14, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. housekeeping Housekeeping-related issue or task. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants