Skip to content

fix: fix blocking on plugin at `online`

Sign in for the full log view
GitHub Actions / clippy failed May 7, 2024 in 1s

clippy

1 error, 3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 3
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check failure on line 213 in src/net/online_fluereflow.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `clone` found for struct `fluere_plugin::PluginManager` in the current scope

error[E0599]: no method named `clone` found for struct `fluere_plugin::PluginManager` in the current scope
   --> src/net/online_fluereflow.rs:213:64
    |
213 |                     let cloned_plugin_manager = plugin_manager.clone();
    |                                                                ^^^^^ method not found in `PluginManager`

Check warning on line 91 in fluereflow/src/types/fluereflow.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (27/7)

warning: this function has too many arguments (27/7)
  --> fluereflow/src/types/fluereflow.rs:63:5
   |
63 | /     pub fn new(
64 | |         source: IpAddr,
65 | |         destination: IpAddr,
66 | |         d_pkts: u32,
...  |
90 | |         tos: u8,
91 | |     ) -> FluereRecord {
   | |_____________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 98 in fluere-config/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> fluere-config/src/init.rs:98:5
   |
97 |     let path_config = path_base.join("fluere");
   |     ------------------------------------------- unnecessary `let` binding
98 |     path_config
   |     ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
97 ~     
98 ~     path_base.join("fluere")
   |

Check warning on line 25 in fluere-config/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded unit expression

warning: unneeded unit expression
  --> fluere-config/src/init.rs:25:21
   |
25 |                     ()
   |                     ^^ help: remove the final `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
   = note: `#[warn(clippy::unused_unit)]` on by default