This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
feat: add gorm plugin #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
requested review from
arugal and
kezhenxu94
and removed request for
kezhenxu94
arugal
reviewed
Nov 18, 2021
Co-authored-by: zhang-wei <zhangwei24@apache.org>
wu-sheng
reviewed
Nov 18, 2021
| @@ -0,0 +1,40 @@ | |||
| # Go2Sky with Gorm | |||
There was a problem hiding this comment.
I think this doc should be linked from https://github.com/SkyAPM/go2sky-plugins#trace-plugins
arugal
reviewed
Nov 18, 2021
gorm/gorm.go
Outdated
|
|
||
| span.SetComponent(s.getComponent()) | ||
| span.SetSpanLayer(agentv3.SpanLayer_Database) | ||
| span.Tag(go2sky.TagDBType, string(s.sqlType)) |
There was a problem hiding this comment.
Do you mean to change this tag TagDBBindVariables in go2sky into tagDbSqlParameters = "db.sql.parameters"?
gorm/gorm.go
Outdated
| span.Tag(go2sky.TagDBType, string(s.sqlType)) | ||
| span.Tag(go2sky.TagDBStatement, sql) | ||
|
|
||
| if len(vars) != 0 { |
There was a problem hiding this comment.
Add reportParam and reportQuery options like this, let the user choose. WDYT?
|
Should this be closed? |
Can you reopen it, or should I raise another PR? |
|
I opened this. |
wu-sheng
approved these changes
Nov 20, 2021
|
@arugal Let's release 1.3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36