Item DFU doesn't fix up banner data

[AzureAaron]

What happened?

The mod's DFU for items cannot fix up banner data resulting in items like the Totem of Corruption appearing as plain white banners without any patterns.

Screenshots

No response

Log output

No response

Minecraft Version

1.20.4

Skyblocker Version

skyblocker-1.16.0+1.20.4.jar

Additional context

No response

[Julienraptor01]

DFU doesn't fix potions either
Basically anything related to additional metadata in newer version is currently not datafixed

Like we have a convertItemId, we should probably designe a convertItemNBT that handle doing all NBTs transformations

Skyblocker/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemFixerUpper.java

Line 299 in 0d6ae15

public static String convertItemId(String id, int damage) {

Skyblocker/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemStackBuilder.java

Line 39 in 0d6ae15

root.put("id", NbtString.of(ItemFixerUpper.convertItemId(id, damage)));

That's one of the improvements i had partially done on my 1.19.2 fork, so i can try to upstream theses changes
I'll try to do it in about a week when my exam session finishes

[AzureAaron]

DFU doesn't fix potions either Basically anything related to additional metadata in newer version is currently not datafixed

Like we have a convertItemId, we should probably designe a convertItemNBT that handle doing all NBTs transformations

Skyblocker/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemFixerUpper.java

Line 299 in 0d6ae15

public static String convertItemId(String id, int damage) {

Skyblocker/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemStackBuilder.java

Line 39 in 0d6ae15

root.put("id", NbtString.of(ItemFixerUpper.convertItemId(id, damage)));

That's one of the improvements i had partially done on my 1.19.2 fork, so i can try to upstream theses changes I'll try to do it in about a week when my exam session finishes

I also wonder to an extent if it'd be possible to use Mojang's DFU for some of this stuff.

[Julienraptor01]

DFU doesn't fix potions either Basically anything related to additional metadata in newer version is currently not datafixed

Like we have a convertItemId, we should probably designe a convertItemNBT that handle doing all NBTs transformations

Skyblocker/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemFixerUpper.java

Line 299 in 0d6ae15

public static String convertItemId(String id, int damage) {

Skyblocker/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemStackBuilder.java

Line 39 in 0d6ae15

root.put("id", NbtString.of(ItemFixerUpper.convertItemId(id, damage)));

That's one of the improvements i had partially done on my 1.19.2 fork, so i can try to upstream theses changes I'll try to do it in about a week when my exam session finishes

I also wonder to an extent if it'd be possible to use Mojang's DFU for some of this stuff.

Maybe ? That could be an idea to investigate
Another thing we could investigate is setup up our own items repo with things already datafixed