Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome DFU #723

Open
IllagerCaptain opened this issue May 19, 2024 · 6 comments
Open

Biome DFU #723

IllagerCaptain opened this issue May 19, 2024 · 6 comments
Labels
new feature This issue or PR is a new feature

Comments

@IllagerCaptain
Copy link

IllagerCaptain commented May 19, 2024

Describe the new feature.

Something I noticed is biomes on SkyBlock are really janked up in newer versions. They appear to stay somewhat correctly shaped, not completely though as that is impossible in newer versions. They are also quite offset, most likely due to the same issue of biomes being stored in batches of blocks instead of per block in newer versions. They also sometimes use the wrong biome, for example, dark oak forest appearing as windswept forest. The wrong biome issue is just a Hypixel issue though and should be easy for them to fix, but overall because some of these issues are due to biomes being stored differently, some of these issues are either not possible or too hard for Hypixel to bother with to fix. So I suggest SkyBlocker to enable the 1.8 biome system while the player is in SkyBlock.

@IllagerCaptain IllagerCaptain added the new feature This issue or PR is a new feature label May 19, 2024
@Fluboxer
Copy link
Contributor

@IllagerCaptain
Copy link
Author

IllagerCaptain commented May 19, 2024

https://hypixel.net/bug-reports/create

Reason I'm reporting here is that biomes are completely different between version and some of these issues cannot be fixed without mods. For example, in 1.8 biomes are stored per block column, but in newer versions they are groups of blocks. What I'm suggesting is to make SkyBlocker use the old biome code while the player is in SkyBlock.

And SkyBlocker also has an item DFU, see #499.

I've updated the post to specify the suggestion better.

@viciscat
Copy link
Collaborator

Reason I'm reporting here is that biomes are completely different between version and some of these issues cannot be fixed without mods.

Items and countless other things are also completely different and hypixel does it just fine.

And SkyBlocker also has an item DFU

I might be wrong but I'm pretty sure the DFU is only for NEU's item-repo

@IllagerCaptain
Copy link
Author

IllagerCaptain commented May 19, 2024

Items and countless other things are also completely different and hypixel does it just fine.

Most of the time when Minecraft changes functionality it adds new options. The issue here is that when biomes added to support 3D, they lost precision. In 1.8 biomes were per column of blocks, but now they are batches of blocks. While Hypixel can somewhat fix it by fixing the offset, this won't fix it completely as that is impossible with the current biome system.

@IllagerCaptain
Copy link
Author

For example, in newer versions when you attempt to set a rectangle to a specific biome, this happens:

@viciscat
Copy link
Collaborator

yeah biome data is indeed less precise, then biome blending does it's things. But that's still an hypixel issue in my humble imho opinion. Depends on the other devs' opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

No branches or pull requests

3 participants