Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line smoothener #711

Merged
merged 2 commits into from
May 14, 2024
Merged

Add line smoothener #711

merged 2 commits into from
May 14, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented May 14, 2024

Turns text with ----------------- into text with a bunch of spaces. The initial text is strikethrough, so it ends up creating bumpy lines like this:

image

This pr turns that into this:

image

Since spaces are narrower than hyphens, I chose an arbitrary amount of spaces.
Also, hypixel seems to have this standard of 17 hyphens, so this applies to pretty much any place that has a hyphen line separator.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 14, 2024
@kevinthegreat1 kevinthegreat1 added the bleeding edge This PR has been accepted into bleeding edge label May 14, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Squash and remove co-author (me) when merging

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels May 14, 2024
@viciscat viciscat merged commit cfff7e1 into SkyblockerMod:master May 14, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label May 14, 2024
@Emirlol Emirlol deleted the smooth-lines branch May 14, 2024 22:03
@kevinthegreat1 kevinthegreat1 removed the bleeding edge This PR has been accepted into bleeding edge label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants