Fix egg found message being sent twice #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
previously approved these changes
May 25, 2024
LifeIsAParadox
added
merge me please
kevinthegreat1
added
the
bleeding edge
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
May 27, 2024
LifeIsAParadox
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should, in theory, fix it since the issue only happens when eggs move around and the eggs get reset to
null. With this, there's no more null setting on new egg spawn (so only on world change, which is irrelevant to this), so the location comparison happens and since the 2nd message's egg location is the same as the 1st one it just doesn't get sent.Might need testing though, maybe there's something I overlooked.