Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raytracing to the egg finder to make it fairer #845

Merged

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Jul 15, 2024

I'm honestly not sure how to explain the changes. Might be better to read commits.
Fixes #832 by adding ray tracing every tick. Also has better logic for waypoints and chat messages, now it doesn't highlight eggs/send messages when the egg was already found in another island, and this state is reset when the egg's reset hour happens, which is at 7, 14, 21 (7am, 2pm, 9 pm)

Also cleans up and improves SkyblockTime. Now it includes hour and refreshes every 50 secs (a skyblock hour). There are also events for when the time unit changes value.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 15, 2024
@Vricken
Copy link
Contributor

Vricken commented Jul 15, 2024

Could the raycast be an option? Like a setting called “enable egg waypoints without seeing them (possibly bannable use at your own risk)” or something like that

@Julienraptor01
Copy link
Contributor

Julienraptor01 commented Jul 15, 2024

Could the raycast be an option? Like a setting called “enable egg waypoints without seeing them (possibly bannable use at your own risk)” or something like that

no, it's not, ESP is a cheat and it's an accident that we included such behavior
tho it's fully open source, so feel free to unpatch it, but it won't be released as an option
(this is just my opinion but i think no one on the team want the mod to become a cheat)

@Emirlol
Copy link
Collaborator Author

Emirlol commented Jul 15, 2024

Could the raycast be an option? Like a setting called “enable egg waypoints without seeing them (possibly bannable use at your own risk)” or something like that

no, it's not, ESP is a cheat and it's an accident that we included such behavior tho it's fully open source, so feel free to unpatch it, but it won't be released as an option (this is just my opinion but i think no one on the team want the mod to become a cheat)

Exactly this. I just never had the thought of whether it was cheaty or not when making it. Took a while to fix due to some skill issues and laziness. This PR is how it should've been since the start.

I know it's currently a bit hard to use, as all it does is tell you if you unobstructed vision to eggs. I was also planning on adding labels for possible locations and egg locator helper for that, but I have other stuff to do for now so those will come separately later on.

@kevinthegreat1 kevinthegreat1 added the bug Something isn't working label Jul 15, 2024
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 26, 2024
@AzureAaron AzureAaron added this to the 1.22 milestone Jul 28, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Aug 2, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 2, 2024
@AzureAaron AzureAaron merged commit 023bf78 into SkyblockerMod:master Aug 3, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 3, 2024
@Emirlol Emirlol deleted the egg-finder-esp-fix-raytracing branch August 4, 2024 05:59
kevinthegreat1 pushed a commit that referenced this pull request Aug 10, 2024
Add raytracing to the egg finder to make it fairer

(cherry picked from commit 023bf78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants