-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waypoints refactor #976
Waypoints refactor #976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I suppose but did not test, might do that at some point.
I’ll wait for aaron to look at this pr. |
src/main/java/de/hysky/skyblocker/skyblock/waypoint/OrderedWaypoints.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/waypoint/OrderedWaypoints.java
Show resolved
Hide resolved
00c33a8
to
3270096
Compare
Closes #1024. |
fb6d881
to
435b7d8
Compare
c48ccef
to
d276f87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incase you forgot just change the ordered waypoints migrator so that it imports under both dwarven mines & CH and then this is good to go
Done. Also some small refactors and Javadoc additions. |
Highlights
Ordered waypoints have been migrated to waypoints gui.
New Skyblocker Waypoints format
API Design
The "wither" pattern is employed. Each class extending
Waypoint
should override all "wither" methods to return a new instance of the subclass to ensure the runtime type of the waypoint is correct.API Changes
I have tried to keep API changes to a minimum, but here are the breaking changes:
Waypoint#setShouldRender
has been renamed toWaypoint#setEnabled
.Waypoint#getColorComponents
has been renamed toWaypoint#getRenderColorComponents
.Waypoint#render
now checksWaypoint#shouldRender
.shouldRender
to false andshouldRenderName
to true.NamedWaypoint#shouldRenderName
now defaults toWaypoint#shouldRender
.shouldRenderName
to always render the name.Bug Fixes