Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: Split populate reviews into 2 phases #157

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jerry-skydio
Copy link
Collaborator

@jerry-skydio jerry-skydio commented Mar 12, 2024

This sets the function up to allow arbitrary topic
order in the future.

The first pass handles finding the relative topic, but
does not assume it's already populated. The second pass
needs to assume that the relative is already populated
since it uses it, so it needs to be done in topological
order (which is a followup pr).

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Mar 12, 2024

Reviews in this chain:
#157 upload: Split populate reviews into 2 phases
 └#158 upload: Add topological_topics as a generator
  └#155 upload: Allow arbitrary topic order
   ├#153 upload: Support Update-Pr-Body as a commit tag
   │└#167 upload: Add "branch-format" config option and commit tag
   └#165 restack: Be topological and update docs

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Mar 12, 2024

# head base diff date summary
0 edb2370d df295937 diff Mar 12 14:07 PM 1 file changed, 9 insertions(+), 6 deletions(-)
1 0a5408f3 df295937 diff Mar 12 15:16 PM 1 file changed, 25 insertions(+), 22 deletions(-)
2 ad555d4a df295937 diff Mar 12 15:20 PM 0 files changed
3 8b3358d6 df295937 diff Mar 12 15:25 PM 1 file changed, 7 insertions(+), 7 deletions(-)
4 fc580cd3 df295937 diff Mar 13 13:40 PM 2 files changed, 3 insertions(+), 4 deletions(-)
5 4231fd44 139ad626 rebase Mar 13 13:46 PM 0 files changed

This sets the function up to allow arbitrary topic
order in the future.

The first pass handles finding the relative topic, but
does not assume it's already populated. The second pass
needs to assume that the relative is already populated
since it uses it, so it needs to be done in topological
order (which is a followup pr).
@jerry-skydio jerry-skydio merged commit 2dfbe6e into main Mar 13, 2024
5 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/order branch March 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants