Add configurable skynet webportal url #7
Conversation
| @@ -52,15 +53,15 @@ function createSkynsEntry(entryUrl) { | |||
| const rawSkylink = parseSkylink(skylink); | |||
| const skylinkDecoded = decodeBase64(rawSkylink); | |||
| const skylinkEncodedBase32 = encodeBase32(skylinkDecoded); | |||
| const skylinkUrl = `https://${skylinkEncodedBase32}.siasky.net`; | |||
| const skylinkUrl = `${portalUrl.protocol}//${skylinkEncodedBase32}.${portalUrl.host}`; | |||
There was a problem hiding this comment.
we should use getSkylinkUrl method to get this link instead of constructing it ourselves
https://github.com/SkynetLabs/skynet-js/blob/master/src/download.ts#L180-L192
You wouldn't need to construct new URL then too
With subdomain option https://github.com/SkynetLabs/skynet-js/blob/master/src/download.ts#L240-L241
|
We're deprecating this repo in favour of SkynetLabs fork https://github.com/SkynetLabs/deploy-to-skynet-action (action from this repo will still work just fine but it's advisable to use the new release from SkynetLabs repo once it's out). It is going to be mostly backwards compatible with one change that if you used registry entry in a hns domain you will need to replace it with the resolver skylink since the data encoding is different. I ported your changes to the pull request we're using to upgrade the repo to use with resolver skylinks - #1 I'll go ahead and close this up, we will continue the development on https://github.com/SkynetLabs/deploy-to-skynet-action so feel free to open up any new pull requests there :) |
support for try-files and not-found-page
Fix #6