Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.Parse or regex? #215

Open
ro-tex opened this issue Jun 1, 2022 · 1 comment
Open

url.Parse or regex? #215

ro-tex opened this issue Jun 1, 2022 · 1 comment
Assignees

Comments

@ro-tex
Copy link
Contributor

ro-tex commented Jun 1, 2022

Looks good to me but out of curiosity is there a reason you didn't choose url.Parse for this?
It comes with methods like Port(), UserPassword etc. which also give you the info you later fetch from the map.

Originally posted by @ChrisSchinnerl in #209 (comment)

@ro-tex
Copy link
Contributor Author

ro-tex commented Jun 1, 2022

Let's continue the conversation here - is it better to use url.Parse or a custom regex. I can see it both ways, so I don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants