Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic when the email configuration is invalid. #209

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix a panic when the email configuration is invalid. #209

merged 2 commits into from
Jun 1, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented May 20, 2022

PULL REQUEST

Overview

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex
Fix a panic when the email configuration is invalid.
b3a502b 
We now return a proper error as we intended to.
Thanks @pcfreak30!
@ro-tex ro-tex self-assigned this May 20, 2022
@MSevey MSevey enabled auto-merge May 20, 2022 14:14
@ro-tex ro-tex mentioned this pull request Jun 1, 2022
Open
@MSevey MSevey merged commit d1c3514 into main Jun 1, 2022
@MSevey MSevey deleted the ivo/fix_email_panic branch June 1, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@MSevey MSevey MSevey approved these changes

@peterjan peterjan Awaiting requested review from peterjan

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ro-tex @ChrisSchinnerl @MSevey