Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API docs for general API keys. #142

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Add API docs for general API keys. #142

merged 2 commits into from
Mar 4, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 4, 2022

PULL REQUEST

Overview

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex ro-tex self-assigned this Mar 4, 2022
kwypchlo
kwypchlo requested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@kwypchlo kwypchlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add example response body for 200s ?

@ro-tex
Add example response bodies to API docs.
d31135f 
Fix a minor bug (default to a sensible value if env val not defined).
@ro-tex ro-tex requested a review from kwypchlo March 4, 2022 11:14
ro-tex
ro-tex commented Mar 4, 2022
View reviewed changes
main.go Show resolved Hide resolved
@ro-tex ro-tex merged commit 477ecd3 into main Mar 4, 2022
@ro-tex ro-tex deleted the ivo/gen_api_keys_docs branch March 4, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@kwypchlo kwypchlo kwypchlo approved these changes

@peterjan peterjan Awaiting requested review from peterjan

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ro-tex @kwypchlo @ChrisSchinnerl