Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle API keys passed in their lower case form. #149

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 9, 2022

PULL REQUEST

Overview

API keys use base32 encoding which is using an all-caps alphabet. We want, however, to allow users to send their API keys in lower case, as well. This will make the user experience smoother.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex ro-tex self-assigned this Mar 9, 2022
Copy link

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ro-tex ro-tex merged commit 0763389 into main Mar 9, 2022
@ro-tex ro-tex deleted the ivo/fix_api_keys_lower_case branch March 9, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants