Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
The
/limits
endpoint returns the bandwidth limits in bits per second, which is the format most people expect to see.The
/user/limits
endpoint, though, returns the bandwidth in bytes per second because that is what Nginx expects to see.This discrepancy is very confusing for users and it needs to be resolved. To that end this PR adds a new query parameter which would let Nginx request the limits in bytes (see SkynetLabs/skynet-webportal#1855) while everyone else will receive the limits in bits.
Example for Visual Changes
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.
Issues Closed