Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DELETE /user/pubkey/:pubKey #159

Merged
merged 6 commits into from
Mar 25, 2022
Merged

Implement DELETE /user/pubkey/:pubKey #159

merged 6 commits into from
Mar 25, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 16, 2022

PULL REQUEST

Overview

Implements DELETE /user/pubkey/:pubKey

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

Closes #147

@ro-tex ro-tex self-assigned this Mar 16, 2022
mrcnski
mrcnski previously approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits.

ChrisSchinnerl
ChrisSchinnerl reviewed Mar 18, 2022
View reviewed changes
api/handlers.go Outdated Show resolved Hide resolved
ChrisSchinnerl
ChrisSchinnerl reviewed Mar 23, 2022
View reviewed changes
database/user.go Outdated Show resolved Hide resolved
ChrisSchinnerl
ChrisSchinnerl previously approved these changes Mar 23, 2022
View reviewed changes
@ro-tex ro-tex requested a review from peterjan March 24, 2022 10:00
peterjan
peterjan approved these changes Mar 25, 2022
View reviewed changes
Copy link

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

api/handlers.go Show resolved Hide resolved
database/user.go Show resolved Hide resolved
@ro-tex ro-tex merged commit 7b6712d into main Mar 25, 2022
@ro-tex ro-tex deleted the ivo/delete_pubkey branch March 25, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@mrcnski mrcnski Awaiting requested review from mrcnski

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DELETE /user/pubkey/:pubkey
4 participants
@ro-tex @peterjan @ChrisSchinnerl @mrcnski