Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement names for API keys. #164

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Implement names for API keys. #164

merged 1 commit into from
Mar 24, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 21, 2022

PULL REQUEST

Overview

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

Closes #155

@ro-tex ro-tex self-assigned this Mar 21, 2022
Copy link

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't API key names be unique per user?

@ro-tex
Copy link
Contributor Author

ro-tex commented Mar 22, 2022

shouldn't API key names be unique per user?

I see no reason to introduce such a limitation. That will mean that there can be only one API key without a name (the name is ""). Even if we add an exception for that, people might want to name their API keys according to the machine that's using them or something like this.

Overall, I don't see an unequivocal benefit of adding this limitation.

@peterjan peterjan merged commit ba4c15e into main Mar 24, 2022
@ro-tex ro-tex deleted the ivo/apikey_names branch March 24, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add names to API keys
3 participants