Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Refactoring and simplification #166

Merged
merged 7 commits into from
Mar 24, 2022
Merged

[MINOR] Refactoring and simplification #166

merged 7 commits into from
Mar 24, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 22, 2022

PULL REQUEST

Overview

The main reason for this PR to exist is to take all minor changes that happened in #165 in order to make it easier to review.

What's done:

  • update golangci-lint
  • replace the heavily outdated golint with its drop-in replacement revive
  • ignore linting errors we've agreed to not fix
  • replace calls to UserSave with specific updates
  • simplify the construction of mongo options structs

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex ro-tex self-assigned this Mar 22, 2022
Makefile Outdated Show resolved Hide resolved
@ro-tex ro-tex merged commit cc99f0d into main Mar 24, 2022
@ro-tex ro-tex deleted the ivo/minor_rf branch March 24, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants