Anonymous uploads + track upload IPs #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement anonymous uploads and downloads.
Fix a bug in downloads, where an unrelated recent download would be updated instead of a new one being created.
# Conflicts: # test/database/user_test.go
peterjan
requested changes
Mar 24, 2022
|
what was the bug by the way? 🙂 |
|
Add an `AnonUser` helper instead of manually creating an empty user.
peterjan
reviewed
Mar 25, 2022
Co-authored-by: Peter-Jan Brone <peter-jan@settlemint.com>
peterjan
approved these changes
Mar 25, 2022
ChrisSchinnerl
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Track anonymous uploads and downloads.
Track the IP of any uploader.
Note:
Don't worry about the anonymous download tracking - we are going to stop tracking downloads, anyway. I just wanted to keep them in sync for the sake of my own mental model. That also helped root out a bug.
Example for Visual Changes
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.
Issues Closed