Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base 10 units instead of base 2 units #168

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Use base 10 units instead of base 2 units #168

merged 1 commit into from
Mar 23, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 23, 2022

PULL REQUEST

Overview

Based on our discussion, we want to switch from using KiB, Kib, MiB, Mib to kB, kb, MB, Mb, i.e. go from 1024 to 1000.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex ro-tex self-assigned this Mar 23, 2022
@kwypchlo kwypchlo merged commit 2e14ef6 into main Mar 23, 2022
@kwypchlo kwypchlo mentioned this pull request Mar 23, 2022
Merged
@ro-tex ro-tex deleted the ivo/mib_to_mb branch March 23, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwypchlo kwypchlo kwypchlo approved these changes

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@peterjan peterjan Awaiting requested review from peterjan

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ro-tex @kwypchlo @ChrisSchinnerl